From: kbusch@kernel.org (Keith Busch)
Subject: nvme cli format question
Date: Thu, 4 Apr 2019 09:45:59 -0600 [thread overview]
Message-ID: <20190404154559.GI16792@localhost.localdomain> (raw)
In-Reply-To: <754e9409-0255-220f-c4c2-18fe55dd4df3@intel.com>
On Wed, Apr 03, 2019@04:03:25PM -0700, Heitke, Kenneth wrote:
>
> What is the expected behavior when calling 'format' on a NVMe character
> device? I see two problems with the code below.
>
> 1) If no namespace Id is specified and the device is not a block device,
> then nvme_identify_ns() is never called and the 'ns' variable used in
> the 'if (cfg.bs)' case is uninitialized.
>
> 2) If the namespace_id is specified or determined from the block device,
> then the 'cfg.bs' check is redundant (and done twice).
Right, not needed. Code yanked.
prev parent reply other threads:[~2019-04-04 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 23:03 nvme cli format question Heitke, Kenneth
2019-04-04 15:45 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404154559.GI16792@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox