From: kbusch@kernel.org (Keith Busch)
Subject: A kernel warning when entering suspend
Date: Thu, 4 Apr 2019 16:29:56 -0600 [thread overview]
Message-ID: <20190404222955.GA25081@localhost.localdomain> (raw)
In-Reply-To: <20190404221948.GB30656@ming.t460p>
On Fri, Apr 05, 2019@06:19:50AM +0800, Ming Lei wrote:
> Also in current blk-mq implementation, one irq may become shutdown
> because of CPU hotplug even though when there is in-flight request
> on the queue served by the irq. Then we depend on timeout handler to
> cover this case, and this irq may be enabled in the timeout handler too,
> please see nvme_poll_irqdisable().
Right, but when the last CPU mapped to an hctx is taken offline, we really
ought to have blk-mq wait for that hctx to reap all outstanding requests
before letting the notifier continue with offlining that CPU. We just
don't have the infrastructure to freeze an individual hctx yet.
next prev parent reply other threads:[~2019-04-04 22:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 8:23 A kernel warning when entering suspend fin4478 fin4478
2019-04-04 8:55 ` Ming Lei
2019-04-04 11:14 ` Thomas Gleixner
2019-12-23 14:52 ` Maxim Levitsky
2020-01-16 13:58 ` Maxim Levitsky
2019-04-04 15:37 ` Dongli Zhang
2019-04-04 16:18 ` Thomas Gleixner
2019-04-04 22:19 ` Ming Lei
2019-04-04 22:29 ` Keith Busch [this message]
2019-04-04 22:50 ` Ming Lei
2019-04-05 11:35 ` Thomas Gleixner
2019-04-06 14:29 ` Dongli Zhang
2019-04-06 15:31 ` Dongli Zhang
2019-04-06 16:12 ` fin4478 fin4478
2019-04-08 15:07 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404222955.GA25081@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox