From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Sun, 7 Apr 2019 00:51:23 -0700 Subject: [PATCH] blk-mq: Wait for for hctx requests on CPU unplug In-Reply-To: References: <20190405215920.27085-1-keith.busch@intel.com> <226503cd-53ac-902c-7944-b2748407b1d3@kernel.dk> <20190405223719.GC25081@localhost.localdomain> Message-ID: <20190407075123.GA22003@infradead.org> On Fri, Apr 05, 2019@05:36:32PM -0600, Keith Busch wrote: > On Fri, Apr 5, 2019@5:04 PM Jens Axboe wrote: > > Looking at current peak testing, I've got around 1.2% in queue enter > > and exit. It's definitely not free, hence my question. Probably safe > > to assume that we'll double that cycle counter, per IO. > > Okay, that's not negligible at all. I don't know of a faster reference > than the percpu_ref, but that much overhead would have to rule out > having a per hctx counter. Can we just replace queue_enter/exit with the per-hctx reference entirely?