From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2] nvmet: make MDTS value configurable
Date: Mon, 8 Apr 2019 08:16:44 +0200 [thread overview]
Message-ID: <20190408061644.GA26437@lst.de> (raw)
In-Reply-To: <90391425-546f-61ad-ca9e-890e0246bf3c@mellanox.com>
On Sun, Apr 07, 2019@03:51:53PM +0300, Max Gurtovoy wrote:
>
> On 4/4/2019 8:27 AM, Christoph Hellwig wrote:
>> On Thu, Apr 04, 2019@01:06:54AM +0200, Hannes Reinecke wrote:
>>> Some drivers and/or use-cases might need to set a smaller MDTS
>>> value, so add a per-port attribute to modify the MDTS value.
>> If the drivers need it they need to communicate that value up the
>> stack. We should not require user inputs to make things work.
>
> I suggested to add ops function.
>
> Something like (pseudo code):
>
>
> static u8 nvmet_rdma_port_mdts(struct nvmet_port *nport)
> {
> ??????? struct nvmet_rdma_port *port = nport->priv;
> ??????? struct rdma_cm_id *cm_id = port->cm_id;
>
> ??????? /* we assume ctrl page_size is 4K */
> ??????? return ilog2(cm_id->device->attrs.max_io_sz / SZ_4K);
> }
>
>
> but after digging the code, there is still work to be done in order to do
> it...
The general idea sounds fine to me. Can you look into it?
next prev parent reply other threads:[~2019-04-08 6:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 23:06 [PATCHv2] nvmet: make MDTS value configurable Hannes Reinecke
2019-04-04 5:27 ` Christoph Hellwig
2019-04-07 12:51 ` Max Gurtovoy
2019-04-08 6:16 ` Christoph Hellwig [this message]
2019-04-08 10:42 ` Max Gurtovoy
2019-04-08 10:50 ` Hannes Reinecke
2019-04-24 17:05 ` Sagi Grimberg
2019-04-25 14:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408061644.GA26437@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox