Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme-cli: Increase size of ONTAP namespace path variable
Date: Wed, 17 Apr 2019 16:46:18 -0600	[thread overview]
Message-ID: <20190417224618.GA6632@localhost.localdomain> (raw)
In-Reply-To: <20190416132740.18045-1-sschricker@suse.de>

On Tue, Apr 16, 2019@06:27:40AM -0700, Simon Schricker wrote:
> nspath's size is ONTAP_NS_PATHLEN and is written to by:
> 
> snprintf(nspath, ONTAP_NS_PATHLEN, "%s%s%s%s", ontap_vol,
>                         vol_name, "/", ns_name);
> 
> Required bytes:
> 
> - ontap_vol is a constant char pointer, set to "/vol/", so 5 bytes
> - vol_name's size is ONTAP_LABEL_LEN, which is 260, deducting the
>   null-byte for termination makes 259 required bytes
> - "/" is 1 byte
> - ns_name's size is also ONTAP_LABEL_LEN, which is 260, deducting
>   the null-byte for termination makes 259 required bytes
> - the final null-byte: 1
> 
> That makes in total 5 + 259 + 1 + 259 + 1 = 525 required bytes

Applied, thanks.

      reply	other threads:[~2019-04-17 22:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 13:27 [PATCH] nvme-cli: Increase size of ONTAP namespace path variable Simon Schricker
2019-04-17 22:46 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417224618.GA6632@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox