From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvmet: loop: kill timeout handler
Date: Mon, 22 Apr 2019 08:57:46 -0600 [thread overview]
Message-ID: <20190422145746.GA13273@localhost.localdomain> (raw)
In-Reply-To: <20190415015146.22580-1-ming.lei@redhat.com>
On Sun, Apr 14, 2019@06:51:46PM -0700, Ming Lei wrote:
> Firstly it doesn't make sense to handle timeout for loop: 1) for admin
> queue, the request is always completed in code path of queuing IO. 2)
> for normal IO request, the timeout on these IOs have been handled by
> underlying queue already.
>
> Secondly nvme-loop's timeout handler is simply broken, and easy to
> cause issue: 1) no any sync/protection between timeout and normal
> completion, and now it is driver's responsibility to deal with
> that; 2) bad reset implementation, blk_mq_update_nr_hw_queues()
> is called after all NSs's queue is stopped(quiesced), and easy
> to trigger deadlock.
>
> So kill the timeout handler.
Makes sense to me, looks good.
Reviewd-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2019-04-22 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 1:51 [PATCH] nvmet: loop: kill timeout handler Ming Lei
2019-04-22 9:55 ` Ming Lei
2019-04-22 14:57 ` Keith Busch [this message]
2019-04-24 16:11 ` Sagi Grimberg
2019-04-25 14:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422145746.GA13273@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox