From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] spec, Makefile: add /etc/nvme files to package files
Date: Thu, 25 Apr 2019 08:59:48 -0600 [thread overview]
Message-ID: <20190425145947.GB17869@localhost.localdomain> (raw)
In-Reply-To: <20190424214942.11288-1-sagi@grimberg.me>
On Wed, Apr 24, 2019@02:49:41PM -0700, Sagi Grimberg wrote:
> This way it can automatically be removed upon uninstallation
> and we don't need %preun target. Also, this will also allow
> to get these files on manual installation from sources.
>
> Also, don't settle on the "file exists" check, use the '-s'
> to check that it is not empty as well.
>
> Lastly, in order to have hostnqn and hostid updated upon pkg
> install, we have install-spec target that would omit hostnqn and
> hostid files, and let the rpm %post do it (otherwise we
> use the normal install target).
Sounds good, applied both patches.
prev parent reply other threads:[~2019-04-25 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 21:49 [PATCH 1/2] spec, Makefile: add /etc/nvme files to package files Sagi Grimberg
2019-04-24 21:49 ` [PATCH 2/2] spec, make: Add discovery.conf to the package files list Sagi Grimberg
2019-04-25 1:15 ` Minwoo Im
2019-04-25 14:59 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425145947.GB17869@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).