From: hare@suse.de (Hannes Reinecke)
Subject: [nvme-cli 6/9] tests/nvme_attach_detach_ns_test.py: skip if namespace mgmt is not supported
Date: Tue, 30 Apr 2019 08:05:51 +0200 [thread overview]
Message-ID: <20190430060554.24368-7-hare@suse.de> (raw)
In-Reply-To: <20190430060554.24368-1-hare@suse.de>
If namespace management is not supported the test will fail, too.
So check for it prior to executing the test.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
tests/nvme_attach_detach_ns_test.py | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/nvme_attach_detach_ns_test.py b/tests/nvme_attach_detach_ns_test.py
index 92a82dd..2225e2c 100644
--- a/tests/nvme_attach_detach_ns_test.py
+++ b/tests/nvme_attach_detach_ns_test.py
@@ -53,18 +53,17 @@ class TestNVMeAttachDetachNSCmd(TestNVMe):
self.nsze = 0x1400000
self.ncap = 0x1400000
self.setup_log_dir(self.__class__.__name__)
- self.ctrl_id = self.get_ctrl_id()
- self.delete_all_ns()
- time.sleep(1)
def __del__(self):
"""
Post Section for TestNVMeAttachDetachNSCmd
- Create primary namespace.
- - Atttach it to controller.
+ - Attach it to controller.
- Call super class's destructor.
"""
+ if self.get_oacs_namespace_mgmt() == 0:
+ return
assert_equal(self.create_and_validate_ns(self.default_nsid,
self.nsze,
self.ncap,
@@ -75,6 +74,12 @@ class TestNVMeAttachDetachNSCmd(TestNVMe):
def test_attach_detach_ns(self):
""" Testcase main """
+ if self.get_oacs_namespace_mgmt() == 0:
+ return
+
+ self.ctrl_id = self.get_ctrl_id()
+ self.delete_all_ns()
+ time.sleep(1)
err = self.create_and_validate_ns(self.default_nsid,
self.nsze,
self.ncap,
--
2.13.7
next prev parent reply other threads:[~2019-04-30 6:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 6:05 [nvme-cli 0/9] Update tests for qemu Hannes Reinecke
2019-04-30 6:05 ` [nvme-cli 1/9] tests/nvme_writezeros_test.py: check if write zeroes is supported Hannes Reinecke
2019-04-30 16:48 ` Heitke, Kenneth
2019-04-30 6:05 ` [nvme-cli 2/9] tests/nvme_writeuncor_test.py: check if write uncorrectable " Hannes Reinecke
2019-04-30 18:56 ` Heitke, Kenneth
2019-04-30 6:05 ` [nvme-cli 3/9] tests/nvme_compare_test.py: check if compare " Hannes Reinecke
2019-04-30 6:05 ` [nvme-cli 4/9] tests: ignore log tests for Qemu Hannes Reinecke
2019-04-30 6:05 ` [nvme-cli 5/9] tests/nvme_text.py: add test for namespace management Hannes Reinecke
2019-04-30 6:05 ` Hannes Reinecke [this message]
2019-04-30 6:05 ` [nvme-cli 7/9] tests/nvme_create_max_ns_test.py: skip if namespace mgmt is not supported Hannes Reinecke
2019-04-30 6:05 ` [nvme-cli 8/9] tests/nvme_get_features_test.py: skip features for Qemu Hannes Reinecke
2019-04-30 6:05 ` [nvme-cli 9/9] tests/nvme_format_test.py: skip test if namespace management is not supported Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430060554.24368-7-hare@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox