From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH V2 3/3] nvme-multipath: improve logging
Date: Tue, 30 Apr 2019 08:33:49 -0700 [thread overview]
Message-ID: <20190430153349.GC26879@infradead.org> (raw)
In-Reply-To: <20190429032442.5923-4-chaitanya.kulkarni@wdc.com>
> + dev_info(ns->ctrl->device,
> + "nvme-mp: status 0x%04x, resetting controller\n",
> + status);
This message still looks a little gibberish to me.
Why not:
"resetting path due to unhandled error (0x%04x")"
> - dev_info(ctrl->device, "ANA group %d: %s.\n",
> + dev_dbg(ctrl->device, "ANA group %d: %s.\n",
> le32_to_cpu(desc->grpid),
> nvme_ana_state_names[desc->state]);
I've applied this hunk to nvme-5.2, thanks.
prev parent reply other threads:[~2019-04-30 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 3:24 [PATCH 0/3] nvme: improve logging Chaitanya Kulkarni
2019-04-29 3:24 ` [PATCH V2 1/3] nvme: introduce nvme-ctrl state name string array Chaitanya Kulkarni
2019-04-29 17:40 ` Heitke, Kenneth
2019-04-29 22:12 ` Chaitanya Kulkarni
2019-04-29 23:27 ` Bart Van Assche
2019-04-29 23:29 ` Sagi Grimberg
2019-04-30 3:18 ` Chaitanya Kulkarni
2019-04-29 3:24 ` [PATCH V2 2/3] nvme: improve logging Chaitanya Kulkarni
2019-04-29 23:18 ` Sagi Grimberg
2019-04-29 3:24 ` [PATCH V2 3/3] nvme-multipath: " Chaitanya Kulkarni
2019-04-29 23:20 ` Sagi Grimberg
2019-04-30 15:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430153349.GC26879@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox