From: mlevitsk@redhat.com (Maxim Levitsky)
Subject: [PATCH 1/2] nvme/pci: init shadow doorbell after each reset
Date: Thu, 2 May 2019 14:31:33 +0300 [thread overview]
Message-ID: <20190502113134.20835-2-mlevitsk@redhat.com> (raw)
In-Reply-To: <20190502113134.20835-1-mlevitsk@redhat.com>
The spec states
"The settings are not retained across a Controller Level Reset"
Therefore the driver must enable the shadow doorbell,
after each reset.
This was caught while testing the nvme driver over
upcoming nvme-mdev device
Signed-off-by: Maxim Levitsky <mlevitsk at redhat.com>
---
drivers/nvme/host/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1f468a16efad..1c844c66ecaa 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2303,8 +2303,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
return ret;
}
dev->ctrl.tagset = &dev->tagset;
-
- nvme_dbbuf_set(dev);
} else {
blk_mq_update_nr_hw_queues(&dev->tagset, dev->online_queues - 1);
@@ -2312,6 +2310,7 @@ static int nvme_dev_add(struct nvme_dev *dev)
nvme_free_queues(dev, dev->online_queues);
}
+ nvme_dbbuf_set(dev);
return 0;
}
--
2.17.2
next prev parent reply other threads:[~2019-05-02 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 11:31 [PATCH 0/2] Few NVME fixes Maxim Levitsky
2019-05-02 11:31 ` Maxim Levitsky [this message]
2019-05-02 13:08 ` [PATCH 1/2] nvme/pci: init shadow doorbell after each reset Keith Busch
2019-05-05 4:18 ` Minwoo Im
2019-05-02 11:31 ` [PATCH 2/2] nvme/pci: add known admin effects to augument admin effects log page Maxim Levitsky
2019-05-08 7:10 ` [PATCH 0/2] Few NVME fixes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502113134.20835-2-mlevitsk@redhat.com \
--to=mlevitsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox