Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCHv3 0/2] nvme: validate CNTLID
Date: Fri,  3 May 2019 15:37:34 +0200	[thread overview]
Message-ID: <20190503133736.111201-1-hare@suse.de> (raw)

Hi all,

here are two patches to validate correct CNTLID information.
A controller might violate the constrain the each CNTLID has to
be unique within a subsystem, which then would cause the host
to crash.
So these patches prevent this situation by validate the CNTLID
and not use the cntlid as part of the device name.

As usual, comments and reviews are welcome.

Changes to v1:
- split cntlid validation into a separate helper and moved to
  nvme_init_subsystem()

Changes to v2:
- move nvme_validate_cntlid() into critical section when adding
  nvme controller to the list as suggested by hch

Hannes Reinecke (2):
  nvme-multipath: avoid crash on invalid subsystem cntlid enumeration
  nvme: validate cntlid during controller initialisation

 drivers/nvme/host/core.c      | 32 ++++++++++++++++++++++++++++++--
 drivers/nvme/host/multipath.c |  2 +-
 2 files changed, 31 insertions(+), 3 deletions(-)

-- 
2.16.4

             reply	other threads:[~2019-05-03 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 13:37 Hannes Reinecke [this message]
2019-05-03 13:37 ` [PATCHv3 1/2] nvme-multipath: avoid crash on invalid subsystem cntlid enumeration Hannes Reinecke
2019-05-03 16:01   ` Keith Busch
2019-05-08  7:54   ` Christoph Hellwig
2019-05-03 13:37 ` [PATCHv3 2/2] nvme: validate cntlid during controller initialisation Hannes Reinecke
2019-05-03 16:16   ` Keith Busch
2019-05-03 19:12   ` Max Gurtovoy
2019-05-04 14:20   ` Minwoo Im
2019-05-08  7:54   ` Christoph Hellwig
2019-05-10 14:51   ` John Donnelly
2019-05-10 18:12     ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503133736.111201-1-hare@suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox