From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme-fc: trace sq head updates
Date: Fri, 3 May 2019 10:23:47 -0600 [thread overview]
Message-ID: <20190503162346.GC30291@localhost.localdomain> (raw)
In-Reply-To: <20190503141459.111641-1-hare@suse.de>
On Fri, May 03, 2019@04:14:59PM +0200, Hannes Reinecke wrote:
> @@ -1675,6 +1678,8 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req)
> }
>
> __nvme_fc_fcpop_chk_teardowns(ctrl, op, opstate);
> + trace_nvme_sq(rq, queue->sq_head,
> + queue->sq_tail % ctrl->ctrl.sqsize);
Correct me if I'm wrong, but don't you need a +1 on that modulo value?
It looks like ctrl.sqsize is set to the last valid index rather than
the actual size.
next prev parent reply other threads:[~2019-05-03 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 14:14 [PATCH] nvme-fc: trace sq head updates Hannes Reinecke
2019-05-03 16:23 ` Keith Busch [this message]
2019-05-03 17:58 ` James Smart
2019-05-04 11:34 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503162346.GC30291@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox