From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH] nvme-pci: Fix queue_count to consider nr_possible_cpu
Date: Sat, 4 May 2019 20:39:23 +0900 [thread overview]
Message-ID: <20190504113923.32316-1-minwoo.im.dev@gmail.com> (raw)
The parameter should be set with the updated count 'n' instead of
'val' itself. The local variable 'cnt' is sized in 6bytes because nvme
supports up to 65536 io queues.
Fixes: 3b6592f70("nvme: utilize two queue maps, one for reads and one
for writes")
Cc: Keith Busch <keith.busch at intel.com>
Cc: Jens Axboe <axboe at fb.com>
Cc: Christoph Hellwig <hch at lst.de>
Cc: Sagi Grimberg <sagi at grimberg.me>
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
drivers/nvme/host/pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 3e4fb891a95a..d3be3193d023 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -147,6 +147,7 @@ static int io_queue_depth_set(const char *val, const struct kernel_param *kp)
static int queue_count_set(const char *val, const struct kernel_param *kp)
{
int n, ret;
+ char cnt[6];
ret = kstrtoint(val, 10, &n);
if (ret)
@@ -154,7 +155,8 @@ static int queue_count_set(const char *val, const struct kernel_param *kp)
if (n > num_possible_cpus())
n = num_possible_cpus();
- return param_set_int(val, kp);
+ sprintf(cnt, "%d", n);
+ return param_set_int(cnt, kp);
}
static inline unsigned int sq_idx(unsigned int qid, u32 stride)
--
2.17.1
next reply other threads:[~2019-05-04 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 11:39 Minwoo Im [this message]
2019-05-08 7:14 ` [PATCH] nvme-pci: Fix queue_count to consider nr_possible_cpu Christoph Hellwig
2019-05-12 13:09 ` Minwoo Im
2019-05-12 14:16 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504113923.32316-1-minwoo.im.dev@gmail.com \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox