From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-pci: fix single segment detection
Date: Thu, 9 May 2019 14:34:06 +0200 [thread overview]
Message-ID: <20190509123406.GB21483@lst.de> (raw)
In-Reply-To: <20190509112410.GA20711@ming.t460p>
On Thu, May 09, 2019@07:24:12PM +0800, Ming Lei wrote:
> I'd suggest to fix block layer instead of working around the issue here,
> then any driver may benefit from the fix.
That is my plan, and I started on it. But the fix isn't trivial, and
will probably take a while and be invasive.
> Especially checking bio->bi_vcnt is just a hack, and drivers should
> never use .bi_vcnt.
That is why it is explicitly commented as a hack. But a good enough
one to still speed up typical 4K I/Os - one a bio has been cloned
chances are very high we don't care about the fast path any more.
next prev parent reply other threads:[~2019-05-09 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 11:04 [PATCH] nvme-pci: fix single segment detection Christoph Hellwig
2019-05-09 11:24 ` Ming Lei
2019-05-09 12:34 ` Christoph Hellwig [this message]
2019-05-09 13:31 ` Ming Lei
2019-05-13 6:26 ` Christoph Hellwig
2019-05-12 15:20 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509123406.GB21483@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox