From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme-cli: cleanup comments for telemetry log structure
Date: Thu, 9 May 2019 10:37:27 -0600 [thread overview]
Message-ID: <20190509163726.GA9675@localhost.localdomain> (raw)
In-Reply-To: <SN6PR04MB4527F16CCAA2E44830391E3A86330@SN6PR04MB4527.namprd04.prod.outlook.com>
On Thu, May 09, 2019@04:38:03PM +0000, Chaitanya Kulkarni wrote:
> Looks good to me.
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
>
> On 05/09/2019 08:43 AM, Akinobu Mita wrote:
> > This removes three comments for struct nvme_telemetry_log_page_hdr.
> >
> > - The comment on top of the definision doesn't describe more than the
> > struct name itself.
> >
> > - The rsvd1 field has already been verified.
> >
> > - The structures with trailing zero size array are commonly used in
> > nvme-cli, so we don't need special comment for telemetry_dataarea[0].
Applied, thanks.
prev parent reply other threads:[~2019-05-09 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 15:43 [PATCH] nvme-cli: cleanup comments for telemetry log structure Akinobu Mita
2019-05-09 16:38 ` Chaitanya Kulkarni
2019-05-09 16:37 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509163726.GA9675@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox