From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@infradead.org (Christoph Hellwig)
Date: Mon, 13 May 2019 06:25:17 -0700
Subject: [PATCH 0/3] nvme-core: add user command filter
In-Reply-To: <20190510214255.GA11723@localhost.localdomain>
References: <20190508183634.4682-1-chaitanya.kulkarni@wdc.com>
 <20190510214255.GA11723@localhost.localdomain>
Message-ID: <20190513132517.GB2661@infradead.org>

On Fri, May 10, 2019@03:42:56PM -0600, Keith Busch wrote:
> On Wed, May 08, 2019@11:36:31AM -0700, Chaitanya Kulkarni wrote:
> > This patch-series adds a filter to allow only certain user commands.                                   
> > Right now we use this infrastructure to prevent the user get log page
> > commands where RAE bit is cleared. We only allow get log pages to be
> > read with RAE == 0 where we issue the uevent to the userspace so that
> > user can clear the log pages.
> > 
> > Here we white list the log pages which are only allowed when RAE == 0.
> > We also allow Vendor Specific log pages irrespective of the RAE.
> 
> I'm generally against the passthrough interface examining commands. It
> is not for the driver to decide what an admin can't send to their devices.

Well, the whole AER model is based around log pages clearing the
event, so if userspace clears these events we are in pretty deep
trouble.  Would you prefer just setting the RAE bit unconditionally
for these log pages?