From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme-core: trace discovery log change AEN
Date: Mon, 13 May 2019 09:35:24 -0700 [thread overview]
Message-ID: <20190513163524.GA32058@infradead.org> (raw)
In-Reply-To: <SN6PR04MB452729CE574409342C30978F860F0@SN6PR04MB4527.namprd04.prod.outlook.com>
On Mon, May 13, 2019@04:32:01PM +0000, Chaitanya Kulkarni wrote:
> > What about just moving the trace_nvme_async_event call before the
> > switch statement?
> >
>
> That is something I avoided since for default case we don't want to
> trace but dev_warn.
>
> But seems like we are okay with trace and dev_warn I'll send a V2.
Doing both sounds fine and even desirable, so that we see the
invalid case in the traces as well as in the dmesg log.
prev parent reply other threads:[~2019-05-13 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 19:33 [PATCH] nvme-core: trace discovery log change AEN Chaitanya Kulkarni
2019-05-08 18:00 ` Chaitanya Kulkarni
2019-05-09 8:27 ` Johannes Thumshirn
2019-05-13 13:24 ` Christoph Hellwig
2019-05-13 16:32 ` Chaitanya Kulkarni
2019-05-13 16:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513163524.GA32058@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox