From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/4] nvme: separate out nvme_ctrl_state_name()
Date: Tue, 21 May 2019 08:46:07 +0200 [thread overview]
Message-ID: <20190521064607.GB30402@lst.de> (raw)
In-Reply-To: <20190520063624.50338-2-hare@suse.de>
> +const char *nvme_ctrl_state_name(struct nvme_ctrl *ctrl)
> +{
> + if ((unsigned)ctrl->state < ARRAY_SIZE(nvme_ctrl_state_names) &&
Can we please drop this odd cast, even if it was there in the old code?
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2019-05-21 6:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 6:36 [PATCH 0/4v3] nvme-fc: track state change failures Hannes Reinecke
2019-05-20 6:36 ` [PATCH 1/4] nvme: separate out nvme_ctrl_state_name() Hannes Reinecke
2019-05-21 6:46 ` Christoph Hellwig [this message]
2019-05-24 6:46 ` Sagi Grimberg
2019-05-24 7:33 ` Hannes Reinecke
2019-05-24 20:34 ` Keith Busch
2019-05-20 6:36 ` [PATCH 2/4] nvme-fc: track state change failures during reconnect Hannes Reinecke
2019-05-21 6:47 ` Christoph Hellwig
2019-05-24 6:51 ` Sagi Grimberg
2019-05-24 7:35 ` Hannes Reinecke
2019-05-20 6:36 ` [PATCH 3/4] nvme-fc: fail reconnect if state change fails Hannes Reinecke
2019-05-21 16:18 ` James Smart
2019-05-22 17:43 ` Arun Easi
2019-05-23 5:33 ` Hannes Reinecke
2019-05-23 15:46 ` James Smart
2019-05-23 15:52 ` [EXT] " Arun Easi
2019-05-20 6:36 ` [PATCH 4/4] nvme-fc: align nvme_fc_delete_association() with exit path Hannes Reinecke
2019-05-21 16:25 ` James Smart
2019-05-22 14:00 ` Hannes Reinecke
2019-05-23 16:01 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521064607.GB30402@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox