From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH 9/9] nvme: Retrieve namespaces during list-subsys cmd
Date: Thu, 23 May 2019 07:39:46 -0600 [thread overview]
Message-ID: <20190523133946.GE14049@localhost.localdomain> (raw)
In-Reply-To: <0c677aa1-aa60-dddd-4a3f-a339545fee63@mellanox.com>
On Thu, May 23, 2019@01:01:54AM -0700, Max Gurtovoy wrote:
>
> On 5/23/2019 1:49 AM, Keith Busch wrote:
> > On Wed, May 22, 2019@07:39:53PM +0300, Max Gurtovoy wrote:
> >> Add an association between subsystems/ctrls/namespaces using
> >> "nvme list-subsys" command. Now this command will show the following:
> >>
> >> nvme-subsys4 - NQN=testsubsystem_0
> >> \
> >> +- nvme4 rdma traddr=12.212.99.85 trsvcid=4420 live
> >> \
> >> +- nvme4n1
> >> +- nvme4n2
> >> +- nvme4n3
> >> +- nvme5 rdma traddr=12.212.99.85 trsvcid=4420 live
> >> \
> >> +- nvme5n1
> >> +- nvme5n2
> >> +- nvme5n3
> >>
> >> Instead of:
> >> ----------------
> >> nvme-subsys4 - NQN=testsubsystem_0
> >> \
> >> +- nvme4 rdma traddr=12.212.99.85 trsvcid=4420
> >> +- nvme5 rdma traddr=12.212.99.85 trsvcid=4420
> > This is a terrific start. Your output indicates you are not using
> > nvme native multipathing, though. Could you retry this command with
> > that enabled (I'll try it tomorrow as well)?
>
> Yup I'll configure the native multipath. But what is expected ?
>
> should we print nvme4c1n1/nvme4c1n2/nvme4c1n3 for nvme4
>
> and nvme4c2n1/nvme4c2n2/nvme4c2n3 for nvme5 ?
>
> if so, I guess the information on the "IO-ble" devices
> nvme4n1/nvme4n2/nvme4n3 will not be printed.
>
> something like:
>
> nvme-subsys4 - NQN=testsubsystem_0
> \
> ?+- nvme4 rdma traddr=12.212.99.85 trsvcid=4420 live
> ?\
> ? +- nvme4c1n1
> ? +- nvme4c1n2
> ? +- nvme4c1n3
> ?+- nvme5 rdma traddr=12.212.99.85 trsvcid=4420 live
> ?\
> ? +- nvme4c2n1
> ? +- nvme4c2n2
> ? +- nvme4c2n3
>
>
> if this if fine I'll send a V2 with a small fix.
I think we'd actually prefer not seeing the hidden block devices, but
instead use the device name from the "head": nvme4n1, nvme4n2, etc...
next prev parent reply other threads:[~2019-05-23 13:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 16:39 [PATCH 0/9] Add Subsystem/Ctrl/Namespace relations Max Gurtovoy
2019-05-22 16:39 ` [PATCH 1/9] nvme: update list-ns nsid option Max Gurtovoy
2019-05-23 4:14 ` Minwoo Im
2019-05-22 16:39 ` [PATCH 2/9] nvme: update description for "nvme list" command Max Gurtovoy
2019-05-23 4:15 ` Minwoo Im
2019-05-22 16:39 ` [PATCH 3/9] fabrics: Fix memory leak of subsys list Max Gurtovoy
2019-05-23 4:18 ` Minwoo Im
2019-05-22 16:39 ` [PATCH 4/9] nvme-print: fix json object memory leak Max Gurtovoy
2019-05-23 4:16 ` Minwoo Im
2019-05-22 16:39 ` [PATCH 5/9] nvme: fix coding style issue Max Gurtovoy
2019-05-23 4:17 ` Minwoo Im
2019-05-22 16:39 ` [PATCH 6/9] nvme: update list-subsys command to show the entire list Max Gurtovoy
2019-05-22 16:39 ` [PATCH 7/9] nvme-print: Introduce show_nvme_ctrl helper Max Gurtovoy
2019-05-22 16:39 ` [PATCH 8/9] nvme-print: Rename "Paths" --> "Ctrls" for json output in list-subsys Max Gurtovoy
2019-05-22 16:39 ` [PATCH 9/9] nvme: Retrieve namespaces during list-subsys cmd Max Gurtovoy
2019-05-22 22:49 ` Keith Busch
2019-05-23 8:01 ` Max Gurtovoy
2019-05-23 13:39 ` Keith Busch [this message]
2019-05-23 14:07 ` hch
-- strict thread matches above, loose matches on Subject: below --
2019-05-23 9:00 [PATCH v2 0/9] Add Subsystem/Ctrl/Namespace relations (nvme-cli) Max Gurtovoy
2019-05-23 9:00 ` [PATCH 9/9] nvme: Retrieve namespaces during list-subsys cmd Max Gurtovoy
2019-05-23 15:11 ` Minwoo Im
2019-05-27 10:01 [PATCH v3 0/9] Add Subsystem/Ctrl/Namespace relations (nvme-cli) Max Gurtovoy
2019-05-27 10:01 ` [PATCH 9/9] nvme: Retrieve namespaces during list-subsys cmd Max Gurtovoy
2019-05-28 19:54 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523133946.GE14049@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox