From: kbusch@kernel.org (Keith Busch)
Subject: [RFC PATCH] nvme: Ignore timeouts while a PCIe reset is pending
Date: Thu, 23 May 2019 15:59:13 -0600 [thread overview]
Message-ID: <20190523215912.GB15192@localhost.localdomain> (raw)
In-Reply-To: <3f191e74-09ed-4356-d467-0ae222018e70@intel.com>
On Thu, May 23, 2019@03:57:22PM -0600, Heitke, Kenneth wrote:
> On 5/22/2019 2:09 PM, Keith Busch wrote:
> > @@ -2782,12 +2783,13 @@ static void nvme_reset_prepare(struct pci_dev *pdev)
> > {
> > struct nvme_dev *dev = pci_get_drvdata(pdev);
> > nvme_dev_disable(dev, false);
> > + nvme_sync_queues(&dev->ctrl);
> > }
> > static void nvme_reset_done(struct pci_dev *pdev)
> > {
> > struct nvme_dev *dev = pci_get_drvdata(pdev);
> > - nvme_reset_ctrl_sync(&dev->ctrl);
> > + nvme_reset_ctrl(&dev->ctrl);
> > }
> > static void nvme_shutdown(struct pci_dev *pdev)
> > --
> >
>
> For my specific case, is the sync_queues and reset_ctrl change needed as
> well?
I shouldn't have included the sync_queue part.
Definitely need the nvme_reset_ctrl change as blk_cfg_access is still
set here so need to reset asynchronously to unblock new timeouts.
next prev parent reply other threads:[~2019-05-23 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 0:37 [RFC PATCH] nvme: Ignore timeouts while a PCIe reset is pending Kenneth Heitke
2019-05-22 19:26 ` Keith Busch
2019-05-22 20:09 ` Keith Busch
2019-05-23 21:57 ` Heitke, Kenneth
2019-05-23 21:59 ` Keith Busch [this message]
2019-05-24 6:45 ` Sagi Grimberg
2019-05-24 21:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523215912.GB15192@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox