From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH 5.0 66/95] nvme: cancel request synchronously
Date: Fri, 24 May 2019 16:23:38 +0800 [thread overview]
Message-ID: <20190524082336.GA1058@ming.t460p> (raw)
In-Reply-To: <09c806a8-7be8-3552-265b-d651aaf848e8@grimberg.me>
On Fri, May 24, 2019@01:15:42AM -0700, Sagi Grimberg wrote:
>
> > > is there an API in the block layer to guaranty that ?
> >
> > So far there isn't yet.
> >
> > And it can be built easily against blk_mq_tagset_busy_iter(), then called
> > in delay-spin style for checking if there is any request marked as
> > MQ_RQ_COMPLETE.
>
> This will probably make blk_mq_complete_request_sync() redundant
> wouldn't it?
Suppose there is new API to drain completed request: blk_mq_wait_completing_rq(),
which has to be called before canceling request.
And it can be used to wait the canceled request too, or keep
blk_mq_complete_request_sync() for avoiding the wait.
Either way should be fine, IMO.
Thanks,
Ming
prev parent reply other threads:[~2019-05-24 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190509181309.180685671@linuxfoundation.org>
2019-05-09 18:42 ` [PATCH 5.0 65/95] blk-mq: introduce blk_mq_complete_request_sync() Greg Kroah-Hartman
2019-05-09 18:42 ` [PATCH 5.0 66/95] nvme: cancel request synchronously Greg Kroah-Hartman
2019-05-21 8:36 ` Max Gurtovoy
2019-05-21 9:45 ` Ming Lei
2019-05-21 10:21 ` Max Gurtovoy
2019-05-21 10:41 ` Ming Lei
2019-05-21 11:50 ` Max Gurtovoy
2019-05-21 12:49 ` Ming Lei
2019-05-24 8:15 ` Sagi Grimberg
2019-05-24 8:23 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524082336.GA1058@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox