From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V5 1/5] nvme: Make trace common for host and target both
Date: Tue, 4 Jun 2019 09:28:53 +0200 [thread overview]
Message-ID: <20190604072853.GG15680@lst.de> (raw)
In-Reply-To: <20190602014737.GA28933@minwooim-desktop>
On Sun, Jun 02, 2019@10:47:38AM +0900, Minwoo Im wrote:
> > I'd much prefer to have different implementations for host vs target for
> > now instead of introducing a common library. Maybe we could revisit
> > that later if we end up having a lot of shared code.
>
> As you know, nvmet handles not only nvme fabrics commands, but normal
> commands in nvmet_req_init() and nvmet_req_complete(). Which means that
> we already have a lot of shared codes in parsing point of view.
>
> The host/trace.c provides parsing admin commands which can be used by
> nvmet also. I guess it's enough to be shared for host and target both.
>
> I hope you can correct me if I missed someting here.
I'm not against sharing per se, but I'm really worried about either
building that code in the core kernel, or even just a new module, as
that'll waste at least 8k and will cause more cache misses when
tracing. So for now my preference would be to just duplicate the code
at least at the binary level.
next prev parent reply other threads:[~2019-06-04 7:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 7:21 [PATCH V5 0/5] nvme-trace: Add support for fabrics command Minwoo Im
2019-06-01 7:21 ` [PATCH V5 1/5] nvme: Make trace common for host and target both Minwoo Im
2019-06-01 8:50 ` Christoph Hellwig
2019-06-02 1:47 ` Minwoo Im
2019-06-04 7:28 ` Christoph Hellwig [this message]
2019-06-04 10:39 ` Minwoo Im
2019-06-04 16:28 ` Sagi Grimberg
2019-06-01 7:21 ` [PATCH V5 2/5] nvme-trace: Support tracing fabrics commands from host-side Minwoo Im
2019-06-01 7:21 ` [PATCH V5 3/5] nvme: Introduce nvme_is_fabrics to check fabrics cmd Minwoo Im
2019-06-01 7:21 ` [PATCH V5 4/5] nvme-trace: Add tracing for req_init in target Minwoo Im
2019-06-01 7:21 ` [PATCH V5 5/5] nvme-trace: Add tracing for req_comp " Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604072853.GG15680@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).