[PATCH V5 1/6] nvme: Do not return in the middle of the subcommand

[minwoo.im.dev@gmail.com (Minwoo Im)]

On 19-06-02 23:03:52, Chaitanya Kulkarni wrote:
> On 5/23/19 6:41 PM, Minwoo Im wrote:
> > Some functions have label with an whitespace, but some don't.   I didn't
> > wanted to involve those kind of clean-up things in this series.  I just made labels
> > with its own function's previuos style, if there's not label, I put an whitespace
> > prior to label.
> >
> > I was thinking that it could be cleaned-up at once later.  Do you really think that
> > those kind of clean-up things are involved in this commit?
> 
> We should at least try and use the default style irrespective of the
> inheriting existing style
> 
> which will trigger more cleanups. Begin said that now the question is
> what is default style ?
> 
> I'd just stick to non space labels as that is something been consistent
> with kernel code.

Hmm... Actually I just tried to do all the added "ret" labels with
non-whitespace in front of it.  But it seems that it's not looking good
though because it just follows the existing style in each functions.
The new label which has been added without any exsiting labels in that
function are good to be updated into default(?) style.

In commit point of view, if a single label breaks the existing labels
style in that function might make the function dirty at the time of
commit.

I would prefer to follow the existing function's style, and for the case
of new label in a function, it will follow the default sytle which is
non-space label.

Inconsistency among the functions are not good, of course.  It should be
cleaned-up later, I guess.

Thanks,