From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [RFC PATCH V6 1/3] nvmet: introduce nvmet_req_to_ctrl to get ctrl instance
Date: Thu, 6 Jun 2019 17:43:41 +0900 [thread overview]
Message-ID: <20190606084341.GA18020@minwooim-desktop> (raw)
In-Reply-To: <20190606064848.GF27033@lst.de>
On 19-06-06 08:48:48, Christoph Hellwig wrote:
> On Thu, Jun 06, 2019@03:32:27PM +0900, Minwoo Im wrote:
> > nvme host driver can get the controller instance from
> > nvme_req(req)->ctrl. In case of target driver, it needs to get
> > controller instance from the struct nvmet_req with sq where the request
> > has been submitted.
>
> Note that normally we can just dereference ->sq just fine, as it only
> isn't set in the low-level code before accepting the initial connect.
That's good point. I just wanted to have safe-code here, but that would
be fine.
> Maybe keep this as a helper in trace.h?
That would be better to put tihs function to nvmet.h once it's needed by
nvmet code later time.
Thanks for your review on this, I'll prepare the V7 series.
next prev parent reply other threads:[~2019-06-06 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 6:32 [RFC PATCH V6 0/3] nvme-trace: Add support for fabrics command Minwoo Im
2019-06-06 6:32 ` [RFC PATCH V6 1/3] nvmet: introduce nvmet_req_to_ctrl to get ctrl instance Minwoo Im
2019-06-06 6:48 ` Christoph Hellwig
2019-06-06 8:43 ` Minwoo Im [this message]
2019-06-06 6:32 ` [RFC PATCH V6 2/3] nvme: trace: do not EXPORT_SYMBOL for a trace function Minwoo Im
2019-06-06 6:48 ` Christoph Hellwig
2019-06-06 15:37 ` Chaitanya Kulkarni
2019-06-06 6:32 ` [RFC PATCH V6 3/3] nvmet: introduce target-side trace Minwoo Im
2019-06-06 6:51 ` Christoph Hellwig
2019-06-06 8:45 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606084341.GA18020@minwooim-desktop \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox