From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [RFC PATCH V7 5/7] nvme: trace: filter out unnecessary fields for fabrics
Date: Sat, 8 Jun 2019 10:38:02 +0900 [thread overview]
Message-ID: <20190608013802.GE1276@minwooim-desktop> (raw)
In-Reply-To: <20190607165244.GH7307@lst.de>
On 19-06-07 18:52:44, Christoph Hellwig wrote:
> On Fri, Jun 07, 2019@04:45:10AM +0900, Minwoo Im wrote:
> > If the given command is for fabrics command, then it should not print
> > out the following fields which are for the !fabrics commands:
> > 1) "flags" (FUSE, PSDT).
> > 2) "nsid" which is reserved in fabrics command.
> > 3) "metadata" which is also reserved in fabrics.
> >
> > To make !fabrics commands clear, don't print them out in case of fabrics
> > commands.
>
> Well, they are all reserved and shall be clared to zero. So I really
> don't see any harm in printing them if we can keep the tracing code
> simpler and the output more regular.
Okay with that. Please let me drop this patch out of this series.
Thanks,
next prev parent reply other threads:[~2019-06-08 1:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 19:45 [RFC PATCH V7 0/7] nvme-trace: Add support for fabrics command Minwoo Im
2019-06-06 19:45 ` [RFC PATCH V7 1/7] nvme: trace: do not EXPORT_SYMBOL for a trace function Minwoo Im
2019-06-06 19:45 ` [RFC PATCH V7 2/7] nvme: trace: move opcode symbol print to nvme.h Minwoo Im
2019-06-07 16:46 ` Christoph Hellwig
2019-06-08 1:57 ` Minwoo Im
2019-06-06 19:45 ` [RFC PATCH V7 3/7] nvme: trace: put cid with le16_to_cpu() Minwoo Im
2019-06-07 16:47 ` Christoph Hellwig
2019-06-08 1:35 ` Minwoo Im
2019-06-06 19:45 ` [RFC PATCH V7 4/7] nvme: trace: support for fabrics commands in host-side Minwoo Im
2019-06-07 16:51 ` Christoph Hellwig
2019-06-08 1:37 ` Minwoo Im
2019-06-06 19:45 ` [RFC PATCH V7 5/7] nvme: trace: filter out unnecessary fields for fabrics Minwoo Im
2019-06-07 16:52 ` Christoph Hellwig
2019-06-08 1:38 ` Minwoo Im [this message]
2019-06-06 19:45 ` [RFC PATCH V7 6/7] nvme: trace: print result and status in hex format Minwoo Im
2019-06-07 16:53 ` Christoph Hellwig
2019-06-06 19:45 ` [RFC PATCH V7 7/7] nvmet: introduce target-side trace Minwoo Im
2019-06-07 16:54 ` Christoph Hellwig
2019-06-08 1:49 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608013802.GE1276@minwooim-desktop \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox