[PATCH 2/3] nvme-pci: remove queue_count_ops for write,poll_queues

[ming.lei@redhat.com (Ming Lei)]

On Mon, Jun 10, 2019@11:25:22AM +0900, Minwoo Im wrote:
> > However, the check is valid, which shouldn't be nop, so could you fix
> > the check instead of removing it?
> 
> Hi, Ming.
> 
> I don't get what you really mean here.   What do you mean "the check is
> valid"? I don't see any valid checks in queue_count_set(), not just for
> check for the failure by kstrtoint().  I think current code is just checks
> the nr_cpus and do nothing after.
> 
> Instead fixing this check inside of this function, I have posted the next
> patch in this series to make sure the number of irqs requested not 
> exceed the num_possible_num().

I suggest to cap 'write_queues' or 'poll_writes' to num_possible_num()
from the beginning, instead of starting with invalid number.


thanks,
Ming