From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v4 3/3] nvme: Set physical block size and optimal I/O size according to NVMe 1.4
Date: Fri, 28 Jun 2019 09:06:57 +0200 [thread overview]
Message-ID: <20190628070657.GC28268@lst.de> (raw)
In-Reply-To: <20190627143215.27443-4-bvanassche@acm.org>
Hi Bart,
> + /*
> + * Bit 1 indicates whether NAWUPF is defined for this namespace
> + * and whether it should be used instead of AWUPF. If NAWUPF == 0
> + * then AWUPF must be used instead.
> + */
> + if (id->nsfeat & (1 << 1) && id->nawupf)
> + atomic_bs = (1 + id->nawupf) * bs;
I think we also need to take the NABO value into account here. Probably
just in that we only set a physical sector size = LBA size, as dealing
with the offsets would be a royal pain (and I've never actually seen
an NVMe device setting the offset either).
Otherwise this looks great to me.
prev parent reply other threads:[~2019-06-28 7:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 14:32 [PATCH v4 0/3] NVMe 1.4 Identify Namespace Support Bart Van Assche
2019-06-27 14:32 ` [PATCH v4 1/3] nvme: Introduce NVMe 1.4 Identify Namespace fields in struct nvme_id_ns Bart Van Assche
2019-06-28 7:00 ` Christoph Hellwig
2019-06-27 14:32 ` [PATCH v4 2/3] nvmet: Export NVMe namespace attributes Bart Van Assche
2019-06-27 17:11 ` Chaitanya Kulkarni
2019-06-28 7:02 ` Christoph Hellwig
2019-06-27 14:32 ` [PATCH v4 3/3] nvme: Set physical block size and optimal I/O size according to NVMe 1.4 Bart Van Assche
2019-06-28 7:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628070657.GC28268@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox