From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH 1/2] nvme-multipath: check singular list in vme_round_robin_path()
Date: Wed, 3 Jul 2019 15:12:31 +0200 [thread overview]
Message-ID: <20190703131232.58595-2-hare@suse.de> (raw)
In-Reply-To: <20190703131232.58595-1-hare@suse.de>
When we have a singular list in nvme_round_robin_path() we still
need to check its validity.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
drivers/nvme/host/multipath.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 499acf07d61a..c8cc82639327 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -178,8 +178,12 @@ static struct nvme_ns *nvme_round_robin_path(struct nvme_ns_head *head,
{
struct nvme_ns *ns, *found, *fallback = NULL;
- if (list_is_singular(&head->list))
+ if (list_is_singular(&head->list)) {
+ if (old->ctrl->state != NVME_CTRL_LIVE ||
+ test_bit(NVME_NS_ANA_PENDING, &old->flags))
+ return NULL;
return old;
+ }
for (ns = nvme_next_ns(head, old);
ns != old;
--
2.16.4
next prev parent reply other threads:[~2019-07-03 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 13:12 [PATCH 0/2] nvme-multipath: path selection fixes Hannes Reinecke
2019-07-03 13:12 ` Hannes Reinecke [this message]
2019-07-03 13:12 ` [PATCH 2/2] nvme-multipath: do not select namespaces which are about to be removed Hannes Reinecke
2019-07-03 13:21 ` Christoph Hellwig
2019-07-03 20:33 ` Sagi Grimberg
2019-07-04 6:00 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2019-07-04 6:10 [PATCHv2 0/2] nvme-multipath: path selection fixes Hannes Reinecke
2019-07-04 6:10 ` [PATCH 1/2] nvme-multipath: check singular list in vme_round_robin_path() Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703131232.58595-2-hare@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox