From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH rfc] nvme-tcp: support simple polling
Date: Tue, 9 Jul 2019 22:22:01 +0200 [thread overview]
Message-ID: <20190709202201.GB8405@lst.de> (raw)
In-Reply-To: <20190703210804.23137-1-sagi@grimberg.me>
On Wed, Jul 03, 2019@02:08:04PM -0700, Sagi Grimberg wrote:
> Simple polling support via socket busy_poll interface.
> Although we do not shutdown interrupts but simply hammer
> the socket poll, we can sometimes find completions faster
> than the normal interrupt driven RX path.
>
> We add per queue nr_cqe counter that resets every time
> RX path is invoked such that .poll callback can return it
> to stay consistent with the semantics.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> There is quite a bit more to do in this direction such as
> asking the net device to allocate polling rings and steer our
> polling queues to them, but that would require some infrastructure
> work in the networking stack.
>
> With this alone, even while still absorbing the net device interrupts
> I'm seeing around 10%-20% latency improvement while sacrificing lots
> of cpu cycles for it.
Looks good enough to me, especially now that we need to explicitly opt
into polling queues.
next prev parent reply other threads:[~2019-07-09 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 21:08 [PATCH rfc] nvme-tcp: support simple polling Sagi Grimberg
2019-07-09 20:22 ` Christoph Hellwig [this message]
2019-07-09 21:26 ` Sagi Grimberg
2019-07-09 21:27 ` Christoph Hellwig
2019-07-09 21:28 ` Sagi Grimberg
2019-07-09 23:07 ` Jens Axboe
2019-07-10 2:15 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709202201.GB8405@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox