From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-multipath: sanitize nvme_update_ana_state()
Date: Tue, 16 Jul 2019 11:38:25 +0200 [thread overview]
Message-ID: <20190716093825.GC32562@lst.de> (raw)
In-Reply-To: <20190716071830.22672-1-hare@suse.de>
On Tue, Jul 16, 2019@09:18:30AM +0200, Hannes Reinecke wrote:
> Commit 04e70bd4a026 ("nvme-multipath: do not select namespaces
> which are about to be removed") introduced checks when traversing
> the list of namespaces to avoid tripping over invalid namespaces.
> A similar check is needed in nvme_update_ana_state() to skip updates
> for any namespaces which will be removed.
> With that we should also remove the WARN_ON() at the end of the
> iteration; this will also be errorneously triggered if ANA Change AENS
> are received during scanning.
What is the problem we are trying to fix here? Just that we should
not call nvme_mpath_set_live? In that case it might make more sense
to move the removed check to just guard that call and at least keep
the values in struct nvme_ns uptodate.
next prev parent reply other threads:[~2019-07-16 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 7:18 [PATCH] nvme-multipath: sanitize nvme_update_ana_state() Hannes Reinecke
2019-07-16 9:38 ` Christoph Hellwig [this message]
2019-07-16 10:02 ` Hannes Reinecke
2019-07-17 14:38 ` Christoph Hellwig
2019-07-18 18:08 ` John Donnelly
2019-07-19 7:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716093825.GC32562@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox