From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 17 Jul 2019 16:38:59 +0200 Subject: [PATCH] nvme-multipath: sanitize nvme_update_ana_state() In-Reply-To: References: <20190716071830.22672-1-hare@suse.de> <20190716093825.GC32562@lst.de> Message-ID: <20190717143859.GA13872@lst.de> On Tue, Jul 16, 2019@12:02:15PM +0200, Hannes Reinecke wrote: > The underlying problem is the 'WARN_ON()', which actually can (and is) > triggered when ANA change AENs are received during controller (re-) connect. > At the same time it's quite pointless to update the ANA state for > namespaces which are on their way out; we _still_ seeing odd behaviour > during simultaneous rescan/reset, and this is just another safeguard. > > But for now I'd be happy to drop the check for NS_REMOVING and just > delete the WARN_ON(). Well, we should certainly skip the nvme_mpath_set_live as well for a removing namespace. But yes, I'd prefer to move the check there and then remove the WARN_ON over the big hammer.