From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH 4/5] nvme: wait until all completed request's complete fn is called
Date: Wed, 24 Jul 2019 09:43:11 +0800 [thread overview]
Message-ID: <20190724014310.GC22421@ming.t460p> (raw)
In-Reply-To: <95f000ba-d3c8-f215-5e32-4b6e44954fb1@grimberg.me>
On Tue, Jul 23, 2019@01:29:54PM -0700, Sagi Grimberg wrote:
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
>
> What about fc? I know that they are not canceling a request, but
> they still complete it, shouldn't it also wait before removing?
fc doesn't use blk-mq request abort mechanism, so its own approach
may sync with abort well.
However, for normal completion, I think the wait is still needed,
will do it in V2.
Thanks,
Ming
next prev parent reply other threads:[~2019-07-24 1:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 5:39 [PATCH 0/5] blk-mq: wait until completed req's complete fn is run Ming Lei
2019-07-22 5:39 ` [PATCH 1/5] blk-mq: introduce blk_mq_request_completed() Ming Lei
2019-07-23 20:26 ` Sagi Grimberg
2019-07-22 5:39 ` [PATCH 2/5] blk-mq: introduce blk_mq_tagset_wait_completed_request() Ming Lei
2019-07-22 15:25 ` Bart Van Assche
2019-07-23 1:06 ` Ming Lei
2019-07-23 20:54 ` Bart Van Assche
2019-07-24 1:34 ` Ming Lei
2019-07-23 20:27 ` Sagi Grimberg
2019-07-22 5:39 ` [PATCH 3/5] nvme: don't abort completed request in nvme_cancel_request Ming Lei
2019-07-22 15:27 ` Bart Van Assche
2019-07-22 23:22 ` Keith Busch
2019-07-23 0:07 ` Sagi Grimberg
2019-07-23 1:08 ` Ming Lei
2019-07-23 19:22 ` Bart Van Assche
2019-07-23 20:27 ` Sagi Grimberg
2019-07-22 5:39 ` [PATCH 4/5] nvme: wait until all completed request's complete fn is called Ming Lei
2019-07-23 16:14 ` Dongli Zhang
2019-07-24 2:05 ` Ming Lei
2019-07-23 20:29 ` Sagi Grimberg
2019-07-24 1:43 ` Ming Lei [this message]
2019-07-22 5:39 ` [PATCH 5/5] blk-mq: remove blk_mq_complete_request_sync Ming Lei
2019-07-23 20:30 ` Sagi Grimberg
2019-07-22 23:27 ` [PATCH 0/5] blk-mq: wait until completed req's complete fn is run Bob Liu
2019-07-23 1:10 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724014310.GC22421@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox