Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 4/5] lnvm: introduce chunk-log command for chunk info
Date: Fri, 26 Jul 2019 00:29:26 +0900	[thread overview]
Message-ID: <20190725152926.GF3018@minwoo-desktop> (raw)
In-Reply-To: <a40ea502-e293-e07c-9f7b-e5f9cc118adf@lightnvm.io>

On 19-07-24 14:27:10, Matias Bj?rling wrote:
> Could you squash patch 2, 3 and 4 together (4 being the main patch) - They
> belong together to implement one feature.
> 
> As a side-note, we have the same command for ZNS (that will be pushed when
> the ZNS TP is ratified) - In that, we've also added support for supplying
> start lba and number of chunks (zones) to return. Could you add that as well
> to this? Then there is coherency between the two?

Matias,

I just had a deep look at your slide about the ZNS which can be found at
[1].  Sorry, I misunderstood your meaning here.

This patch already introduced the SLBA in its chunk, but no nr_chunks in
a single summary line.  Do you want me to print it like:

	root at host:~/nvme-cli.git# nvme lnvm chunk-log /dev/nvme0n1
	nr_chunks: 480
	 [    0] { cs: 0x2, ct: 0x1, wli: 2, slba: 0x0000000000000000, cnlb: 0x0000000000001000, wp: 0x0000000000001000 }
	 [    1] { cs: 0x2, ct: 0x1, wli: 1, slba: 0x0000000000001000, cnlb: 0x0000000000001000, wp: 0x0000000000001000 }
	 [    2] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x0000000000002000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }
	 [    3] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x0000000000003000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }
	 [    4] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x0000000000004000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }
	 [    5] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x0000000000005000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }
	 [    6] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x0000000000006000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }
	...
	 [  478] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x00000000001fa000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }
	 [  479] { cs: 0x1, ct: 0x1, wli: 0, slba: 0x00000000001fb000, cnlb: 0x0000000000001000, wp: 0x0000000000000000 }

Thanks!

[1] https://nvmexpress.org/wp-content/uploads/NVMeAnnualMeeting2019-ZNSv3.pptx

  parent reply	other threads:[~2019-07-25 15:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 18:35 [PATCH 0/5] nvme-cli: lnvm: introduce chunk-log command Minwoo Im
2019-07-23 18:35 ` [PATCH 1/5] lnvm: make data_len to sizeof() instead of magic number Minwoo Im
2019-07-24  7:14   ` Javier González
2019-07-24 12:33   ` Matias Bjørling
2019-07-25 13:46     ` Minwoo Im
2019-07-23 18:35 ` [PATCH 2/5] lnvm: export lnvm_get_identity Minwoo Im
2019-07-24  7:24   ` Javier González
2019-07-23 18:35 ` [PATCH 3/5] lnvm: add chunk_info log page structure Minwoo Im
2019-07-23 18:36 ` [PATCH 4/5] lnvm: introduce chunk-log command for chunk info Minwoo Im
2019-07-24  7:22   ` Javier González
2019-07-25 13:37     ` Minwoo Im
2019-07-25 13:53       ` Javier González
2019-07-24 12:27   ` Matias Bjørling
2019-07-25 13:43     ` Minwoo Im
2019-07-25 15:29     ` Minwoo Im [this message]
2019-07-27 15:25       ` Matias Bjørling
2019-07-27 17:55         ` Minwoo Im
2019-07-23 18:36 ` [PATCH 5/5] lnvm: introduce alias geometry for id-ns for lnvm Minwoo Im
2019-07-24 12:29   ` Matias Bjørling
2019-07-25 13:53     ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725152926.GF3018@minwoo-desktop \
    --to=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox