From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 3/4] nvme: lightnvm: trace opcode name
Date: Sun, 28 Jul 2019 12:12:06 +0900 [thread overview]
Message-ID: <20190728031206.GA24390@minwoo-desktop> (raw)
In-Reply-To: <bf4212ea-8c08-61eb-39cd-c43a5186125c@lightnvm.io>
Hi Matias,
> We should not pollute the standardilized NVMe code with vendor-specific
> opcodes. The above code assumes generally that an opcode is associated as an
> admin opcode - this is true for an OCSSD 1.2 drive, but not so for any other
> vendor's drive.
Agree with that. I was thinking that these are nothing but an opcodes
which could be not a pollusion, but you're right other vendors are not
suitable for these opcodes.
> Besides that, I don't think we should add anymore code for 1.2 since it is
> deprecated.
Okay, I think I need to think about how to trace the nvme commands for
the vendor-specific commands with minimal changes.
Thanks!
next prev parent reply other threads:[~2019-07-28 3:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 18:41 [PATCH 0/4] nvme: update way to get qid in trace Minwoo Im
2019-07-27 18:41 ` [PATCH 1/4] nvme: simplify nvme_req_qid() Minwoo Im
2019-07-27 18:41 ` [PATCH 2/4] nvme: check admin queue with ctrl->admin_q, not rq_disk Minwoo Im
2019-07-27 18:41 ` [PATCH 3/4] nvme: lightnvm: trace opcode name Minwoo Im
2019-07-27 19:36 ` Matias Bjørling
2019-07-28 3:12 ` Minwoo Im [this message]
2019-07-27 18:41 ` [PATCH 4/4] nvme: lightnvm: trace opcode name of I/O commands for 2.0 Minwoo Im
2019-07-27 19:47 ` Matias Bjørling
2019-07-28 3:15 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728031206.GA24390@minwoo-desktop \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox