From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH rfc v2 2/6] nvme: return nvme_error_status for sync commands failure
Date: Fri, 2 Aug 2019 19:49:51 -0700 [thread overview]
Message-ID: <20190803024955.29508-3-sagi@grimberg.me> (raw)
In-Reply-To: <20190803024955.29508-1-sagi@grimberg.me>
callers should not rely on raw nvme status, blk_status_t
is more appropriate.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/host/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d2b4f57fa67e..f435c85c4062 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -803,7 +803,7 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
if (nvme_req(req)->flags & NVME_REQ_CANCELLED)
ret = -EINTR;
else
- ret = nvme_req(req)->status;
+ ret = nvme_error_status(req);
out:
blk_mq_free_request(req);
return ret;
@@ -894,7 +894,7 @@ static int nvme_submit_user_cmd(struct request_queue *q,
if (nvme_req(req)->flags & NVME_REQ_CANCELLED)
ret = -EINTR;
else
- ret = nvme_req(req)->status;
+ ret = nvme_error_status(req);
if (result)
*result = le32_to_cpu(nvme_req(req)->result.u32);
if (meta && !ret && !write) {
--
2.17.1
next prev parent reply other threads:[~2019-08-03 2:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 2:49 [PATCH rfc v2 0/6] nvme controller reset and namespace scan work race conditions Sagi Grimberg
2019-08-03 2:49 ` [PATCH rfc v2 1/6] nvme: fail cancelled commands with NVME_SC_HOST_PATH_ERROR Sagi Grimberg
2019-08-04 7:56 ` Minwoo Im
2019-08-03 2:49 ` Sagi Grimberg [this message]
2019-08-04 7:57 ` [PATCH rfc v2 2/6] nvme: return nvme_error_status for sync commands failure Minwoo Im
2019-08-05 18:12 ` Sagi Grimberg
2019-08-03 2:49 ` [PATCH rfc v2 3/6] nvme: make nvme_identify_ns propagate errors back Sagi Grimberg
2019-08-04 8:06 ` Minwoo Im
2019-08-05 12:39 ` Hannes Reinecke
2019-08-05 18:18 ` Sagi Grimberg
2019-08-06 6:33 ` Hannes Reinecke
2019-08-03 2:49 ` [PATCH rfc v2 4/6] nvme: make nvme_report_ns_ids propagate error back Sagi Grimberg
2019-08-03 2:49 ` [PATCH rfc v2 5/6] nvme-tcp: fail command with NVME_SC_HOST_PATH_ERROR send failed Sagi Grimberg
2019-08-03 2:49 ` [PATCH rfc v2 6/6] nvme: don't remove namespace if revalidate failed because of a transport error Sagi Grimberg
[not found] ` <e04be8bf-20cb-db7d-6046-74d8ec6fa485@broadcom.com>
2019-08-05 19:32 ` Fwd: [PATCH rfc v2 0/6] nvme controller reset and namespace scan work race conditions James Smart
2019-08-05 19:48 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190803024955.29508-3-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox