From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Mon, 5 Aug 2019 12:35:58 -0600 Subject: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers In-Reply-To: <40a6acc2-beae-3e36-ca20-af5801038a1e@grimberg.me> References: <20190730153044.GA13948@localhost.localdomain> <2030a028664a9af9e96fffca3ab352faf1f739e5.camel@kernel.crashing.org> <6290507e1b2830b1729fc858cd5c20b85d092728.camel@kernel.crashing.org> <20190805134907.GC18647@localhost.localdomain> <40a6acc2-beae-3e36-ca20-af5801038a1e@grimberg.me> Message-ID: <20190805183557.GA22859@localhost.localdomain> On Mon, Aug 05, 2019@11:27:54AM -0700, Sagi Grimberg wrote: > > > > Ping ? I had another look today and I don't feel like mucking around > > > with all the AQ size logic, AEN magic tag etc... just for that sake of > > > that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem > > > to make much of a difference in practice anyway. > > > > > > But if you feel strongly about it, then I'll implement the "proper" way > > > sometimes this week, adding a way to shrink the AQ down to something > > > like 3 (one admin request, one async event (AEN), and the empty slot) > > > by making a bunch of the constants involved variables instead. > > > > I don't feel too strongly about it. I think your patch is fine, so > > > > Acked-by: Keith Busch > > Should we pick this up for 5.3-rc? Probably not. While I don't think this is a risky patch set, it's not a bug fix for anything we introduced during the merge window. Christoph also stated he wanted this to go in the 5.4 merge window.