From: marcos.souza.org@gmail.com (Marcos Paulo de Souza)
Subject: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait
Date: Tue, 6 Aug 2019 07:24:56 -0300 [thread overview]
Message-ID: <20190806102456.GA29914@continental> (raw)
In-Reply-To: <20190806051911.GA13409@lst.de>
On Tue, Aug 06, 2019@07:19:11AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 05, 2019@10:17:51PM -0300, Marcos Paulo de Souza wrote:
> > +void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
> > + int at_head, rq_end_io_fn *done)
>
> We store a ->rq_disk in struct request, so we should also not need
> that. And at_head should either become a bool, or be replaced with
> a flags argument, ints used boolean are usually not a good idea.
Makes sense.
>
> > @@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
>
> And all the same argument changes that apply to blk_execute_rq_nowait
> apply to blk_execute_rq as well.
Thanks for the suggestions, I will send a v2 soon.
prev parent reply other threads:[~2019-08-06 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 1:17 [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait Marcos Paulo de Souza
2019-08-06 5:19 ` Christoph Hellwig
2019-08-06 10:24 ` Marcos Paulo de Souza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806102456.GA29914@continental \
--to=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox