From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC31FC4CEC9 for ; Wed, 18 Sep 2019 02:15:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF55E218AE for ; Wed, 18 Sep 2019 02:15:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FDkq1GOk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xCFCihNa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF55E218AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+NXa4qEM613EFIHzibVDQfJggMW/5cYmr8M1ZYuU7A4=; b=FDkq1GOkVH9kO+ QIhkUJ1tGjUipJ81asughzXbJsHGFOHQdyc/2ejHH8ZrONHLA5CwvLhyfTeqAtpWPPXFYH7VFKk0l wSqh1XIOcVLGVpgUsV04tRdNrPkB/BVIEW1Xb0rZq7xcA7qMh7B08srPfAQD30AbNjp14xzRCZhtr lqPryuiq3YRcr36RjSm6ySElpSKGWfs71Muq4RDHZ9Eh6GX7GJOolPLBwuy7/pZW9YF+DUkyjn13w MZkgdl2uvN9xYa3MTDN6OrtzwwhcxpuJA9rrEnWveijGbclC0Qsxqwj4u5DFow0Hvnq6QkcvXwCHs NB442q/2I86Y+KpXdEXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAPVT-0005pq-RZ; Wed, 18 Sep 2019 02:15:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAPVR-0005oU-Hv for linux-nvme@lists.infradead.org; Wed, 18 Sep 2019 02:15:46 +0000 Received: from C02WT3WMHTD6 (unknown [8.36.226.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C76B5214AF; Wed, 18 Sep 2019 02:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568772943; bh=Zz3l/EfVQ6u0ouFqV5ZU/f3gPYSJg8m+QpxfTAe/muc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xCFCihNa7mv+XXuWHlcVmoNLQeRUhUdIfPhmNPpJ75KrYXTxSwcoHnOufhLFQ5AQF JqHxQFfcGss0soW/LNBdpTymruPLxzsezeT2iZTbda/2Ll3Mcc32y/NmwgvEPY/L/N ep5xpqTguTFJMA1vpjWYos7SAvx1Bb0nGUM+3Ry8= Date: Tue, 17 Sep 2019 20:15:41 -0600 From: Keith Busch To: Balbir Singh Subject: Re: [PATCH v4] nvme/host/pci: Fix a race in controller removal Message-ID: <20190918021541.GA45690@C02WT3WMHTD6> References: <20190918002720.18330-1-sblbir@amzn.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190918002720.18330-1-sblbir@amzn.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_191545_617053_A8CF11AE X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@fb.com, hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Sep 18, 2019 at 12:27:20AM +0000, Balbir Singh wrote: > User space programs like udevd may try to read to partitions at the > same time the driver detects a namespace is unusable, and may deadlock > if revalidate_disk() is called while such a process is waiting to > enter the frozen queue. On detecting a dead namespace, move the disk > revalidate after unblocking dispatchers that may be holding bd_butex. Patch looks fine. Reviewed-by: Keith Busch _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme