Re: [PATCHv2 2/6] nvme: Remove ADMIN_ONLY state

Christoph Hellwig
2019-09-27T21:35:29Z

On Fri, Sep 20, 2019 at 06:34:27AM +0900, kbusch@kernel.org wrote:
> @@ -3585,11 +3571,9 @@ static void nvme_scan_work(struct work_struct *work)
> struct nvme_id_ctrl *id;
> unsigned nn;
>
> - if (ctrl->state != NVME_CTRL_LIVE)
> + if (ctrl->state != NVME_CTRL_LIVE || !ctrl->tagset)
> return;
>
> - WARN_ON_ONCE(!ctrl->tagset);
> -

It would be nice to throw in a comment here on why tagset can be NULL
here and what that means to make this a little easier to decode for
future hackers. Except for that the patch looks fine to me.