From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6A2C432C2 for ; Thu, 26 Sep 2019 03:28:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E23921E6F for ; Thu, 26 Sep 2019 03:28:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KVAh4zN6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ALObapA8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E23921E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F9Bq11WfWsjoOEwZ+cgieFPdB+FJmbTDUQwtz1URHps=; b=KVAh4zN67RmNiN S+6Mf/M5zAVUIl+bL1IHSrJMe5ooSUEitIwSZlJrfB4W+67cSd7CIE3LUibzMDScxauBwr6Y3NzP9 C2OiTOzVN+T/IWUlxVZcE5wc+RiF6kZgeVdCgBviJigozufCHQyyuGoZ+GB0jY82YwL8Xs4Ge4Bal cP+4GKeF9mT/8CFbX9OaW4pEq02Wfgbt4zgKN9I5m9Zbi3MrRfQuq/UdlWJesS/UvFovKCBnrDhLm MLBVu6xVwR2TUPnp3Tam2nN0oR4OIMuGGH6TI8cA05xkrMibKOP3sLvXUtKC7eXWgzK8rqtOH3+9H LIYQc7ai0g5gS5CxFC5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDKS9-0004pj-Do; Thu, 26 Sep 2019 03:28:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDKS6-0004pG-B2 for linux-nvme@lists.infradead.org; Thu, 26 Sep 2019 03:28:24 +0000 Received: from C02WT3WMHTD6 (rap-us.hgst.com [199.255.44.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C20921E6F; Thu, 26 Sep 2019 03:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569468501; bh=84gq12HknZ7XPseL/r2FquFiLU/nmkUX+yyYPXZ1s10=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ALObapA8a5/CpsZQlbepxZxqAD1+LinCt/PWojmXcdfGsQDzPA1EeSXtzh9BsnZ7z fQH0CP4y6SKsWfXy5EygI5C9BXpROlXpXo8s5B/pz+CK0dmagTKIWH0sR8n7CRdyDu aTxL75MPCPiJoJVYJ13IkCccf3AkS9EnIMUpe/l0= Date: Wed, 25 Sep 2019 20:28:19 -0700 From: Keith Busch To: Sagi Grimberg Subject: Re: [PATCH v2] nvme: Add ctrl attributes for queue_count and sqsize Message-ID: <20190926032819.GA13013@C02WT3WMHTD6> References: <20190926002023.14033-1-jsmart2021@gmail.com> <4d1cea96-1352-eaae-6bee-cc179b2a6400@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4d1cea96-1352-eaae-6bee-cc179b2a6400@grimberg.me> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190925_202822_404947_BC817EBC X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Smart , linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Sep 25, 2019 at 05:28:49PM -0700, Sagi Grimberg wrote: > > > v2: > > Updated is_visible to not show sqsize attribute on pcie controllers > > Why? isn't sqsize assigned for pci controllers as well? I only noticed this comment in the 'struct nvme_ctrl' definition: /* Fabrics only */ u16 sqsize; But since it's been questioned, I see pcie does indeed set this field, and the code comment was the only source of confusion. So sure, the original patch is fine in that sense. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme