Re: [PATCHv2 1/6] nvme-pci: Free tagset if no IO queues

Sagi Grimberg
2019-09-20T17:56:28Z

>>> +static void nvme_free_tagset(struct nvme_dev *dev)
>>> +{
>>> + if (dev->tagset.tags)
>>> + blk_mq_free_tag_set(&dev->tagset);
>>> + dev->ctrl.tagset = NULL;
>>> +}
>>> +
>>
>> testing dev->tagset.tags and nulling dev->ctrl.tagset?
>> why not check dev->ctrl.tagset?
>
> We could theoretically use either. I don't see any case where we've
> allocated dev->tagset.tags but didn't set dev->ctrl.tagset. But I
> just kept the same check we had before, just moved it into a helper
> function.

Yea, just looks a bit strange now that its in its own function.

Not a real issue though...

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>