From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F85C4360C for ; Sat, 28 Sep 2019 00:24:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C53782075D for ; Sat, 28 Sep 2019 00:24:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MbOLqJS2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JejXdjCj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C53782075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=apM3pN2E22cBf/hcWSE5Jq+z9NP2ICdRgjrpzuXlC7M=; b=MbOLqJS2XfOnBT dxV/PXev6m0lLGl7Xi5ApKIaJgSMem2Eb2DgUGiHXwV6KXUyj/46deLAxnqxhy9zY6d5Z7IUEBR1t yuU2TU5xF/ynNOdz6Fxlhp6eP4Mel2R1j3G7+q1tJDlx0qukDypR4rVyrvwkHEkMzvmPZSIe/cNwV GooRwJBFJAwsb2g4XGy3ARAtAv79zCv0GLS0Px49+/vpn9OlQ4wpMdK8Er96enInG+yhJrdF4vI46 rTzYOBs2aafg8f0BGTNfEy3UGt/viuHRT5bZrqzm8hcU/i9O5dQqPHSMRd3xFR+D8j1JUIh/bYQb0 uU9yyF0Lm7rSTbq4ssBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iE0Wk-0002ET-74; Sat, 28 Sep 2019 00:23:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iE0We-0002Dq-Ms for linux-nvme@lists.infradead.org; Sat, 28 Sep 2019 00:23:53 +0000 Received: from C02WT3WMHTD6 (unknown [8.36.226.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 148BD2075D; Sat, 28 Sep 2019 00:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569630231; bh=ZkLwsfW/lzDFTaaBRVo/5VLy7GMr1CvgbmYDLMzEOpA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JejXdjCj1PPh+ZbdJJyXUyjAw4a5ahlwflOJCpu8Pjrn03voZlniVMBRk7dhXn0ZT S6LMcdz1DwC7qZOnZkRu2I3/mYDHlRHsanA486Z+ilBhWDaaGFZ5MHvti1AwDAWwPI cmQy6QLN7wdb+RWHTDSqNYWyqrVW8wT4eh03YDmM= Date: Fri, 27 Sep 2019 18:23:49 -0600 From: Keith Busch To: Christoph Hellwig Subject: Re: [PATCHv2 5/6] nvme: Prevent resets during paused states Message-ID: <20190928002349.GA17232@C02WT3WMHTD6> References: <20190919213431.7864-1-kbusch@kernel.org> <20190919213431.7864-6-kbusch@kernel.org> <20190927214121.GK16819@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190927214121.GK16819@lst.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190927_172352_768492_361265A0 X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Edmund Nadolski , Sagi Grimberg , linux-nvme@lists.infradead.org, James Smart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Sep 27, 2019 at 11:41:21PM +0200, Christoph Hellwig wrote: > On Fri, Sep 20, 2019 at 06:34:30AM +0900, kbusch@kernel.org wrote: > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > > index 95b74d020506..33b5729763c2 100644 > > --- a/drivers/nvme/host/core.c > > +++ b/drivers/nvme/host/core.c > > @@ -3742,15 +3742,14 @@ static void nvme_fw_act_work(struct work_struct *work) > > if (time_after(jiffies, fw_act_timeout)) { > > dev_warn(ctrl->device, > > "Fw activation timeout, reset controller\n"); > > - nvme_reset_ctrl(ctrl); > > - break; > > + nvme_reset_continue(ctrl); > > + return; > > Hmm, I find the use of a function named nvme_reset_continue here > rather confusing, as there is no reset we are continuing. Yes, we place > the controller in resetting state, but it isn't really a reset in the A PAUSED state would have to copy the same transitions that RESETTING has. It seems simpler to just collapse this with the existing RESETTING state, and we also don't need a special way to schedule reset_work from it. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme