From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F77ECA9ED3 for ; Mon, 4 Nov 2019 15:30:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5498020842 for ; Mon, 4 Nov 2019 15:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VK8ormB5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5498020842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fmSi4cfgIFBqWMqdfrXaLjEhrz5A/PbEkMpArF+wSYM=; b=VK8ormB5VZ6rI6 EJnYei35ox3PeC082TQ95R8a01N/NvXAume4jFJd1/YDmwHFCRAdWz27DQ8NMgg3Q8rtN0YMI3fj7 MjeOLi3RWiZtm1xbz+i6y9ZAtk78rOWx4BObQ/ZxAJn0V8wgMpWvGA7tsxWk/CmA5cujI1sznF5Ir gKbGQi6H0Gb/tDzMHm33TJmZe15vjX5joAoxQ+GvQTncKGO60BSCDGiy3lWmhpLSxtEJ82UVp7MyL UTwRIVXdoT9Pv25gbi710Bw90UBXnm6hb1gQ9WPUB/bbPHkf6HIiZYUF7O03PEH8rBrQoEt99dqyT sYCO8OGcQeouNDdJGxJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iReJM-00043n-6s; Mon, 04 Nov 2019 15:30:32 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iReJJ-00043J-LQ for linux-nvme@lists.infradead.org; Mon, 04 Nov 2019 15:30:30 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BA19A68BE1; Mon, 4 Nov 2019 16:30:27 +0100 (CET) Date: Mon, 4 Nov 2019 16:30:27 +0100 From: Christoph Hellwig To: Charles Machalow Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field. Message-ID: <20191104153027.GC17050@lst.de> References: <20191031050338.12700-1-csm10495@gmail.com> <20191031133921.GA4763@lst.de> <1977598237.90293761.1572878080625.JavaMail.zimbra@kalray.eu> <871357470.90297451.1572879417091.JavaMail.zimbra@kalray.eu> <266047531.90300507.1572880575232.JavaMail.zimbra@kalray.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_073029_849959_389F31B3 X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Marta Rybczynska , linux-kernel , linux-nvme , axboe , kbusch , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Nov 04, 2019 at 07:20:43AM -0800, Charles Machalow wrote: > The thing with that structure is if you use it with the old IOCTL, the > result will go into rsvd2 instead of the first 32 bits of result. But if you use the old ioctls on the new structure you can at least expect that. And with the added explicit padding it will at least do the right thing on 32-bit x86 as well. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme