From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87ECC432C0 for ; Wed, 20 Nov 2019 18:48:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A10092071C for ; Wed, 20 Nov 2019 18:48:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBudKAxO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A10092071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F2B4N3oJO+JblYiwd37mEDFYfQJWMQeTjfBZ8lWpW2I=; b=PBudKAxOOnB5wW GhkdHLLcuj5nbc6X6InUf6Eg0cuua4/QVFiqdUePNimftlCm4mbFZQeZSRTe0tYGSknmKJJzRHpB3 TIzRSIX4dIvDGfUc1Mm5qApjgNMj33F8Kn52WN827P6Z3OQgDpREWujoGaYkgCqYJ9pejvoZEozTx aYHE30QqY13E3HB41FFOCwcBxQRYUSDq5VnUdrqXu4JppVk1jBgbG2Ki1OY0Q2btEdk6IHQhOJl1R mRRcrN/DtQTKp+2GTaR7vJ9d8WDnxNRqw/PB8tTn3zRhWlYl+FFG11u8CKH9+4YxuFOkTlYlUCGkA CQYjW/G/4/IOf/kJqaoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXV1n-0002FR-KP; Wed, 20 Nov 2019 18:48:35 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXV1l-0002Et-JJ for linux-nvme@lists.infradead.org; Wed, 20 Nov 2019 18:48:34 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9E6B268C7B; Wed, 20 Nov 2019 19:48:28 +0100 (CET) Date: Wed, 20 Nov 2019 19:48:27 +0100 From: Christoph Hellwig To: Akinobu Mita Subject: Re: [PATCH v2 1/2] nvme: hwmon: provide temperature min and max values for each sensor Message-ID: <20191120184827.GA12322@lst.de> References: <1573746001-20979-1-git-send-email-akinobu.mita@gmail.com> <1573746001-20979-2-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573746001-20979-2-git-send-email-akinobu.mita@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_104833_784375_D2A516B0 X-CRM114-Status: UNSURE ( 7.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Jean Delvare , Sagi Grimberg , linux-nvme@lists.infradead.org, Jens Axboe , Keith Busch , Christoph Hellwig , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 12:40:00AM +0900, Akinobu Mita wrote: > +/* These macros should be moved to linux/temperature.h */ > +#define MILLICELSIUS_TO_KELVIN(t) DIV_ROUND_CLOSEST((t) + 273150, 1000) > +#define KELVIN_TO_MILLICELSIUS(t) ((t) * 1000L - 273150) Didn't we want to move this to a generic header? Otherwise this looks good: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme