From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3680C432C0 for ; Mon, 2 Dec 2019 22:22:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FF9A207DD for ; Mon, 2 Dec 2019 22:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j7ttWnE0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="H7u1D5q3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FF9A207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NekvGMa4mB4jNMGyfjBU8uZwvfYaw6cD/3H7T+NStjc=; b=j7ttWnE0+WtHLV Pyh+sWph5vL1HkHBbopGN/l7sP/ocDnL3J1rNblFqpAMj1choOKBaFF/l1lEfcg+Ger8KDZcYDmRR hZ0gdNdT+PZadNZtBPNa+TlDza9UeqwZAYU3tpIRQ0VPqcbo0qItv5DQPo71giD3OQISplGRQLQ+x t+e7v3vEN1pNTdlq66zw1IDodH+8fmeGeWqTO2ToKRQp/SZ8HEwjR+XufPpWkB2EQ6T3PtSuHseJm Iy+K1R0PQIP/KMP82+pVxV5qzyYm9OGkKe0tNKQX4gaL4Yvuz1QvtyWj1Am6pjWdWQDOW8OEWZ4v9 Ome8J7vDZQhKTzjC8ovQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibu5T-0007JF-08; Mon, 02 Dec 2019 22:22:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibu55-0006zy-6q for linux-nvme@lists.infradead.org; Mon, 02 Dec 2019 22:22:14 +0000 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CDF92084B; Mon, 2 Dec 2019 22:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575325330; bh=CzNRtaiOi7BWcDYM66uX3CjvuxiHXNXv++Puruukb5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H7u1D5q38xyalOV4O+yhbr0Kyt+Mr0yWE1rbR0LD8ZLLLvMRoUbqZvBCat3fSxGSe LJP838TiGi2HkNUpy513Q0XFClFTKCm1v9PQxZUKA+xLengYp0hprtigp3Fb//8D1w rhE3J5UOKctLfCdeFHX8dnlUykz1OYYNMt8SmRXw= From: Keith Busch To: linux-nvme@lists.infradead.org Subject: [RFC PATCH 2/3] nvme/pci: Remove use_threaded_interrupts parameter Date: Tue, 3 Dec 2019 07:22:05 +0900 Message-Id: <20191202222206.2225-3-kbusch@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191202222206.2225-1-kbusch@kernel.org> References: <20191202222206.2225-1-kbusch@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_142211_368642_AAFD7468 X-CRM114-Status: GOOD ( 10.01 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , bigeasy@linutronix.de, ming.lei@redhat.com, hch@lst.de, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org The non-threaded nvme completion handler provides no additional benefit over the threaded one. Remove the option. Signed-off-by: Keith Busch --- drivers/nvme/host/pci.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index c811c0984fe0..634c96bafb70 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -42,9 +42,6 @@ #define NVME_MAX_KB_SZ 4096 #define NVME_MAX_SEGS 127 -static int use_threaded_interrupts; -module_param(use_threaded_interrupts, int, 0); - static bool use_cmb_sqes = true; module_param(use_cmb_sqes, bool, 0444); MODULE_PARM_DESC(use_cmb_sqes, "use controller's memory buffer for I/O SQes"); @@ -1529,14 +1526,8 @@ static int queue_request_irq(struct nvme_queue *nvmeq) struct pci_dev *pdev = to_pci_dev(nvmeq->dev->dev); int nr = nvmeq->dev->ctrl.instance; - if (use_threaded_interrupts) { - return pci_request_irq(pdev, nvmeq->cq_vector, nvme_irq_check, - nvme_irq_thread, nvmeq, "nvme%dq%d", nr, - nvmeq->qid); - } else { - return pci_request_irq(pdev, nvmeq->cq_vector, nvme_irq, - NULL, nvmeq, "nvme%dq%d", nr, nvmeq->qid); - } + return pci_request_irq(pdev, nvmeq->cq_vector, nvme_irq_check, + nvme_irq_thread, nvmeq, "nvme%dq%d", nr, nvmeq->qid); } static void nvme_init_queue(struct nvme_queue *nvmeq, u16 qid) -- 2.21.0 _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme