From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: hare@suse.de, John Meneghini <johnm@netapp.com>,
hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme-multipath: do not reset on unknown status
Date: Thu, 20 Feb 2020 17:47:04 +0100 [thread overview]
Message-ID: <20200220164704.GA13560@lst.de> (raw)
In-Reply-To: <20200220145241.12982-1-kbusch@kernel.org>
On Thu, Feb 20, 2020 at 11:52:41PM +0900, Keith Busch wrote:
> From: John Meneghini <johnm@netapp.com>
>
> The nvme multipath error handling defaults to controller reset if the
> error is unknown. There are, however, no existing nvme status codes that
> indicate a reset should be used, and resetting causes unnecessary
> disruption to the rest of IO.
>
> Change nvme's error handling to first check if failover should happen.
> If not, let the normal error handling take over rather than reset the
> controller.
>
> Signed-off-by: John Meneghini <johnm@netapp.com>
> [changelog]
> Signed-off-by: Keith Busch <kbusch@kernel.org>
This pretty much looks like my edited version of Hanne's patch with
John's changelog and your edits..
> if ((req->cmd_flags & REQ_NVME_MPATH) &&
> + nvme_failover_req(req))
> - blk_path_error(status)) {
> - nvme_failover_req(req);
> + nvme_failover_req(req))
This conditional could now fit onto a single line.
Otherwise this looks fine to me.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-20 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:52 [PATCH] nvme-multipath: do not reset on unknown status Keith Busch
2020-02-20 16:47 ` Christoph Hellwig [this message]
2020-02-20 17:17 ` Meneghini, John
2020-02-20 19:39 ` Hannes Reinecke
2020-03-10 21:06 ` Keith Busch
2020-03-10 22:08 ` Meneghini, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220164704.GA13560@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=johnm@netapp.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox