From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B308AC10F27 for ; Tue, 10 Mar 2020 16:52:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8344120873 for ; Tue, 10 Mar 2020 16:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oc03Sl2d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8344120873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+2nloOhC3Zm4o+5eENf8JWZ6H/CpcfLW0JiGVmNBHEQ=; b=oc03Sl2dA6ZTf2 ToDhp2Y8vk8rLjrg71/WwjDemiUmOGu64hNX9FljoMpQOvNkzRs5/aJCQMZ9I6BYTVXnELo7/dfSi Z3zaYMc/BnKOkpzTF7XAKGF9DezJ5thUAmnYZmmKm34bV+k2hHMKOlZVKGB7RjlZYC89s3xleFFvd S9y+dWAlNTbrUQFpjimNambGUp/gmjYwOaFnPR9CPKcoAtf+bVLmHlqbWrCcqCsZOX0Xnup42xbYd Z4AMR5BJkDDMMu8ruC9/xEVPx2O1MJ8TUAz68rxdNXdLAWZ7NVOuhNiXaIIJr56RPFaKNDOPrIf1X 3plO5HQNJhaW5pmmuxeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBi7A-0000Oo-Rf; Tue, 10 Mar 2020 16:52:20 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBi78-0000O5-3P for linux-nvme@lists.infradead.org; Tue, 10 Mar 2020 16:52:19 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AE6BA68BE1; Tue, 10 Mar 2020 17:52:15 +0100 (CET) Date: Tue, 10 Mar 2020 17:52:15 +0100 From: Christoph Hellwig To: Hannes Reinecke Subject: Re: [PATCH 1/3] nvmet/fc: Sanitize tgtport reference counting for LS requests Message-ID: <20200310165215.GA7034@lst.de> References: <20200306130440.16864-1-hare@suse.de> <20200306130440.16864-2-hare@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200306130440.16864-2-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200310_095218_291984_6CC90562 X-CRM114-Status: GOOD ( 10.84 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Keith Busch , Chaitanya Kulkarni , James Smart , linux-nvme@lists.infradead.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > @@ -482,14 +476,19 @@ nvmet_fc_xmt_disconnect_assoc(struct nvmet_fc_tgt_assoc *assoc) > struct nvmefc_ls_req *lsreq; > int ret; > > + if (!nvmet_fc_tgtport_get(tgtport)) > + return; > + > /* > * If ls_req is NULL or no hosthandle, it's an older lldd and no > * message is normal. Otherwise, send unless the hostport has > * already been invalidated by the lldd. > */ > if (!tgtport->ops->ls_req || !assoc->hostport || > - assoc->hostport->invalid) > + assoc->hostport->invalid) { > + nvmet_fc_tgtport_put(tgtport); > return; > + } > > lsop = kzalloc((sizeof(*lsop) + > sizeof(*discon_rqst) + sizeof(*discon_acc) + > @@ -498,6 +497,7 @@ nvmet_fc_xmt_disconnect_assoc(struct nvmet_fc_tgt_assoc *assoc) > dev_info(tgtport->dev, > "{%d:%d} send Disconnect Association failed: ENOMEM\n", > tgtport->fc_target_port.port_num, assoc->a_id); > + nvmet_fc_tgtport_put(tgtport); > return; > } > > @@ -522,6 +522,7 @@ nvmet_fc_xmt_disconnect_assoc(struct nvmet_fc_tgt_assoc *assoc) > "{%d:%d} XMT Disconnect Association failed: %d\n", > tgtport->fc_target_port.port_num, assoc->a_id, ret); > kfree(lsop); > + nvmet_fc_tgtport_put(tgtport); Can you consolidate all the calls in this function using goto unwinding? Otherwise looks good. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme