From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: bijan.mottahedeh@oracle.com, hch@lst.de,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCHv2 2/3] nvme-pci: Remove two-pass completions
Date: Tue, 10 Mar 2020 17:57:50 +0100 [thread overview]
Message-ID: <20200310165750.GB7114@lst.de> (raw)
In-Reply-To: <20200304181246.481835-3-kbusch@kernel.org>
On Wed, Mar 04, 2020 at 10:12:45AM -0800, Keith Busch wrote:
> Completion handling had been done in two steps: find all new completions
> under a lock, then handle those completions outside the lock. This was
> done to make the locked section as short as possible so that other
> threads using the same lock wait less time.
>
> The driver no longer shares locks during completion, and is in fact
> lockless for interrupt driven queues, so the optimization no longer
> serves its original purpose. Replace the two-pass completion queue
> handler with a single pass that completes entries immediately.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-10 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 18:12 [PATCHv2 0/3] nvme-pci: process cq improvements Keith Busch
2020-03-04 18:12 ` [PATCHv2 1/3] nvme-pci: Remove tag from process cq Keith Busch
2020-03-05 20:53 ` Sagi Grimberg
2020-03-10 16:56 ` Christoph Hellwig
2020-03-04 18:12 ` [PATCHv2 2/3] nvme-pci: Remove two-pass completions Keith Busch
2020-03-05 9:50 ` Dongli Zhang
2020-03-05 15:15 ` Keith Busch
2020-03-05 20:53 ` Sagi Grimberg
2020-03-10 16:57 ` Christoph Hellwig [this message]
2020-03-04 18:12 ` [PATCHv2 3/3] nvme-pci: Simplify nvme_poll_irqdisable Keith Busch
2020-03-05 20:55 ` Sagi Grimberg
2020-03-10 17:02 ` Christoph Hellwig
2020-03-10 19:16 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310165750.GB7114@lst.de \
--to=hch@lst.de \
--cc=bijan.mottahedeh@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).