From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme/fc: use real sqsize as argument when connecting queues
Date: Tue, 17 Mar 2020 13:47:01 +0100 [thread overview]
Message-ID: <20200317124701.GC12316@lst.de> (raw)
In-Reply-To: <20200316174819.GB1069991@dhcp-10-100-145-180.wdl.wdc.com>
On Mon, Mar 16, 2020 at 10:48:19AM -0700, Keith Busch wrote:
> On Fri, Mar 13, 2020 at 01:48:08PM +0100, Hannes Reinecke wrote:
> > When creating queues we should be passing in the real sqsize number,
> > and not increasing it by one just so that the function has to
> > substract it again.
>
> Kind of makes me wonder: why are we even passing the sq size as a
> parameter at all? The 'ctrl' parameter provides the same thing.
Yes, please kill the parameter entirely instead.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-17 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 12:48 [PATCH] nvme/fc: use real sqsize as argument when connecting queues Hannes Reinecke
2020-03-13 20:24 ` Sagi Grimberg
2020-03-14 14:45 ` Hannes Reinecke
2020-03-16 17:48 ` Keith Busch
2020-03-17 12:47 ` Christoph Hellwig [this message]
2020-03-26 14:08 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317124701.GC12316@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).