From: Christoph Hellwig <hch@infradead.org>
To: Nick Bowler <nbowler@draconx.ca>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Fix NVME_IOCTL_ADMIN_CMD compat address handling.
Date: Wed, 25 Mar 2020 12:11:03 -0700 [thread overview]
Message-ID: <20200325191103.GA6495@infradead.org> (raw)
In-Reply-To: <20200325002847.2140-1-nbowler@draconx.ca>
A couple of comments:
No need for the "." the end of the subject line.
I also think you should just talk of the nvme_user_cmd function,
as that also is used for the NVME_IOCTL_IO_CMD ioctl. Also there now
is a nvme_user_cmd64 variant that needs the same fix, can you also
include that?
> + if (in_compat_syscall()) {
> + /*
> + * On real 32-bit kernels this implementation ignores the
> + * upper bits of address fields so we must replicate that
> + * behaviour in the compat case.
s/real //g please, there are no fake 32-vit kernels :)
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-25 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 0:28 [PATCH] nvme: Fix NVME_IOCTL_ADMIN_CMD compat address handling Nick Bowler
2020-03-25 6:54 ` Sagi Grimberg
2020-03-25 18:26 ` Keith Busch
2020-03-25 19:11 ` Christoph Hellwig [this message]
2020-03-25 20:15 ` Nick Bowler
2020-03-25 20:43 ` Keith Busch
2020-03-25 20:47 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325191103.GA6495@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nbowler@draconx.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox